Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start a grape with
dht_ephemeral: true
anddht_adaptive: true
and if the grape is long running - between 20-30mins (randomized range) uptime - the grape will become persistent (join the DHT).This can be a useful mode for reducing network noise and guarding against triggering cascading failure scenarios - if a peer keeps crashing, but it's in adaptive mode, then it will never join the DHT. Whereas if the peer is persistent (
dht_ephemeral: false
) on init, it will be constantly exiting and rejoining the DHT.Default is still
dht_ephemeral: false
but it might be worth consideringdht_ephemeral: true
,adaptive: true
as default in a future iteration.WIP because we need holepunchto/hyperdht#27 to land first