Get rid of Head response cache #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnau Mora Gras <[email protected]>
ArnyminerZ
added
refactoring
2 tasks
2 tasks
…d-by-412-response-to-get-w-if-match
rfc2822
approved these changes
Dec 6, 2024
rfc2822
deleted the
1150-webdav-etag-cache-is-not-invalidated-by-412-response-to-get-w-if-match
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Right now, the ETag of a WebDAV file is stored in cache, when already been opened by Android. The issue is that this is enforced, so if the file is modified on the server, the cached ETag is used, which doesn't match the correct one, so the request fails with 412.
See #1150 for more info.
Short description
Got rid of
HeadResponseCache, so theHEADrequest is always made upon opening a WebDAV file.Checklist