Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncer SecurityException: disable permission notification for now #1284

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Syncer SecurityException: disable permission notification for now #1284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions app/src/main/kotlin/at/bitfire/davdroid/sync/Syncer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import at.bitfire.davdroid.repository.DavCollectionRepository
import at.bitfire.davdroid.repository.DavServiceRepository
import at.bitfire.davdroid.resource.LocalCollection
import at.bitfire.davdroid.resource.LocalDataStore
import at.bitfire.davdroid.ui.NotificationRegistry
import dagger.hilt.android.qualifiers.ApplicationContext
import java.util.logging.Level
import java.util.logging.Logger
Expand Down Expand Up @@ -71,9 +70,6 @@ abstract class Syncer<StoreType: LocalDataStore<CollectionType>, CollectionType:
@Inject
lateinit var logger: Logger

@Inject
lateinit var notificationRegistry: NotificationRegistry

@Inject
lateinit var serviceRepository: DavServiceRepository

Expand Down Expand Up @@ -251,7 +247,8 @@ abstract class Syncer<StoreType: LocalDataStore<CollectionType>, CollectionType:
dataStore.acquireContentProvider()
} catch (e: SecurityException) {
logger.log(Level.WARNING, "Missing permissions for content provider authority ${dataStore.authority}", e)
notificationRegistry.notifyPermissions()
/* Don't show a notification here without possibility to permanently dismiss it!
Some users intentionally don't grant all permissions for what is syncable. */
null
}.use { provider ->
if (provider == null) {
Expand Down