Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Apache Commons by native calls/Guava #883

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Replace Apache Commons by native calls/Guava #883

merged 3 commits into from
Jul 4, 2024

Conversation

rfc2822
Copy link
Member

@rfc2822 rfc2822 commented Jul 3, 2024 •
edited
Loading

Closes #882

Purpose

See #882

Short description

  • Use Android Formatter for human-readable file sizes
  • Use Guava for stream copying etc.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@rfc2822 rfc2822 linked an issue Jul 3, 2024 that may be closed by this pull request
Get rid of Apache Commons #882
Closed
@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Jul 3, 2024
@rfc2822 rfc2822 self-assigned this Jul 3, 2024
@rfc2822 rfc2822 marked this pull request as ready for review July 3, 2024 10:05
@rfc2822 rfc2822 requested a review from sunkup July 3, 2024 10:53
sunkup
sunkup approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@rfc2822 rfc2822 merged commit 56f7b4b into main-ose Jul 4, 2024
8 checks passed
@rfc2822 rfc2822 deleted the 882-get-rid-of-apache-commons-if-possible branch July 4, 2024 14:00
This was referenced Jul 4, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunkup sunkup sunkup approved these changes

Assignees

@rfc2822 rfc2822

Labels
refactoring Internal improvement of existing functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of Apache Commons
2 participants
@rfc2822 @sunkup