Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coincidence naming of LocalCollection members #957

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

sunkup
Copy link
Member

@sunkup sunkup commented Aug 6, 2024

Purpose

Remove / Fix the coincidentally equal overlappning names in LocalCollection of the implementing classes (LocalCalendar and LocalJtxCollection) which extend classes, that already have members of the same name (AndroidCalendar and JtxCollection).

  • <i>LocalCollection : fun delete(): Boolean
  • LocalCalendar : implicit (coincidentally) implemented by
  • AndroidCalendar : fun delete(): Boolean

and

  • <i>LocalCollection : val url: String?
  • LocalJtxCollection : implicitly (coincidentally) implemented by
  • JtxCollection : var url: String?

Short description

In LocalCollection rename:

  • delete() to deleteCollection()
  • url to collectionUrl

Update one log statement to use the new way of acquiring the logger.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@sunkup sunkup added the refactoring Internal improvement of existing functions label Aug 6, 2024
@sunkup sunkup self-assigned this Aug 6, 2024
@sunkup sunkup linked an issue Aug 6, 2024 that may be closed by this pull request
@sunkup sunkup requested a review from ArnyminerZ August 6, 2024 09:56
Copy link
Member

@ArnyminerZ ArnyminerZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me :)

Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I think we have to re-order the methods in LocalCalendar etc. at some time because the order seem quite random.

@rfc2822 rfc2822 merged commit eae6d0c into main-ose Aug 8, 2024
8 checks passed
@rfc2822 rfc2822 deleted the 953-localcollection-fix-coincidence-naming branch August 8, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal improvement of existing functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LocalCollection: fix "coincidence" naming
3 participants