Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate EditCalendarActivity to Compose #174

Closed
wants to merge 22 commits into from
Closed

Conversation

ArnyminerZ
Copy link
Member

No description provided.

Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
@ArnyminerZ ArnyminerZ added the enhancement New feature or request label Aug 22, 2023
@ArnyminerZ ArnyminerZ self-assigned this Aug 22, 2023
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
@ArnyminerZ ArnyminerZ marked this pull request as ready for review August 22, 2023 11:03
@ArnyminerZ ArnyminerZ requested review from rfc2822 and sunkup August 22, 2023 11:03
# Conflicts:
#	app/build.gradle
@rfc2822
Copy link
Member

rfc2822 commented Sep 10, 2023

Thanks! Unfortunately, reviewing a +957 −176 PR is almost impossible for me right now. It takes far too much time to this properly.

Please split the rewrite to Compose into smaller PRs, ideally with these conditions:

  • PRs should not add more lines (except comments etc.) than ~ 100 lines in sum (i.e. added lines minus removed lines). Ideally, every PR removes more line than it adds –
  • No new features, UI redesigns, animations etc…; only what is absolutely necessary. We can add other things later when the big migration is done.
  • Only one PR after the other (at any time not more than 1 open PR regarding Compose).

I hope this could result in a better work flow that is also more satisfying for you.

Sorry, something went wrong.

@rfc2822 rfc2822 removed their request for review September 10, 2023 13:21
@rfc2822 rfc2822 removed the request for review from sunkup September 10, 2023 13:21
@ArnyminerZ ArnyminerZ marked this pull request as draft September 11, 2023 17:31
@ArnyminerZ ArnyminerZ closed this Nov 20, 2023
@ArnyminerZ ArnyminerZ deleted the compose_edit_calendar branch March 14, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants