-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix metaField/requestField/responseField types #259
Conversation
When is this going to be merged? |
the real changes we need to merge I believe are:
I don't know about the rest. I can merge and release if you rebase with only those changes. We can open another issue to address the rest of the base interface refactoring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please only include changes for metaField
requestField
and responseField
.
@bithavoc I agree, my problem would be fixed when only |
@bithavoc Changes made, please take another look |
Great, I agree there is some repetition, but we can fix that in another PR. I'm ready to merge, do you want to rebase to squash your commits in a single commit or you want github to do it? |
extract shared base interface make BaseErrorLoggerOptions extend BaseSharedLogger Options Roll back type deduplication revert object -> Record change
@bithavoc done |
Thank you. |
Thank you 🙏 |
Addresses #256