Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

Strip sensitive URL parameters from provider log output #292

Merged
merged 1 commit into from
Aug 3, 2016

Conversation

nickmiller-wf
Copy link
Contributor

@nickmiller-wf nickmiller-wf commented Aug 3, 2016

Resolves #291

After searching through the providers package manually, I determined the GitHub provider and validateToken helper function were the only areas at risk here. Other providers, like Google, encode their sensitive parameters as a form-encoded body, and they are never logged.

@jehiah

@nickmiller-wf
Copy link
Contributor Author

For the record, I'm not tied to the name stripToken - naming these little helper functions can be tough sometimes. I'm happy to change it if something else seems more appropriate.

@jehiah
Copy link
Member

jehiah commented Aug 3, 2016

perfect. and a test for bonus points!

Can you squash down to a single commit?

@nickmiller-wf
Copy link
Contributor Author

🎉

@jehiah jehiah merged commit a0e4a36 into bitly:master Aug 3, 2016
@nickmiller-wf nickmiller-wf deleted the redact-access-token branch August 3, 2016 04:03
@nickmiller-wf
Copy link
Contributor Author

@jehiah When should we expect a new release to be cut? Was having some trouble trying to build locally

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants