Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

When loading client-id/client-secret/cookie-secret from env variables, google_auth_proxy blows up. #40

Merged
merged 1 commit into from
Nov 15, 2014

Conversation

jehiah
Copy link
Member

@jehiah jehiah commented Nov 15, 2014

e.g.

export GOOGLE_AUTH_PROXY_COOKIE_SECRET=foo
export GOOGLE_AUTH_PROXY_CLIENT_SECRET=bar
export GOOGLE_AUTH_PROXY_CLIENT_ID=baz

google_auth_proxy -http-address=127.0.0.1:8443 -upstream=http://127.0.0.1:8080/ -redirect-url=https://foo.bar -google-apps-domain=foo.bar

errors out as:

panic: runtime error: assignment to entry in nil map

goroutine 16 [running]:
runtime.panic(0x74eac0, 0x98be13)
    /usr/local/go/src/pkg/runtime/panic.c:279 +0xf5
main.LoadOptionsFromEnv(0x719100, 0xc20808e000, 0x0)
    /root/gopath/src/github.com/bitly/google_auth_proxy/env_options.go:30 +0x3d1
main.main()
    /root/gopath/src/github.com/bitly/google_auth_proxy/main.go:58 +0x9ff

@jehiah
Copy link
Member

jehiah commented Nov 15, 2014

Thanks for catching this; It was clearly broken in the recent refactoring.

jehiah added a commit that referenced this pull request Nov 15, 2014
When loading client-id/client-secret/cookie-secret from env variables, google_auth_proxy blows up.
@jehiah jehiah merged commit 5199e00 into bitly:master Nov 15, 2014
@ipmb ipmb mentioned this pull request Jan 18, 2015
@jehiah jehiah deleted the env_parsing_40 branch March 20, 2015 03:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant