-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client-go version bump to release-7.0 #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I note this leaves a few unused libraries - and it looks like you added the roots of the k8s modules rather than specific packages (common govendor UX issue).
Can you run govendor remove +m +u
over this? Then lgtm.
also includes version bumps of k8s.io/api and k8s.io/apimachinery to release-1.10 with a new vendor of github.com/json-iterator/go due to an issue (kubernetes/apimachinery#46) with client-go v7.0 addresses bitnami-labs#110
0139e92
to
51aaa46
Compare
I think I did the |
Perfect, thanks again! bors r+ |
👎 Rejected by too few approved reviews |
Oops, try again: bors r+ |
126: client-go version bump to release-7.0 r=anguslees a=jipperinbham also includes version bumps of k8s.io/api and k8s.io/apimachinery to release-1.10 with a new vendor of github.com/json-iterator/go due to an issue (kubernetes/apimachinery#46) with client-go v7.0 addresses #110 Co-authored-by: JP Phillips <[email protected]>
Build succeeded |
🕺 |
also includes version bumps of k8s.io/api and k8s.io/apimachinery to release-1.10 with a new vendor of github.com/json-iterator/go due to an issue (kubernetes/apimachinery#46) with client-go v7.0
addresses #110