Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client-go version bump to release-7.0 #126

Merged
merged 1 commit into from
Nov 13, 2018

Conversation

jipperinbham
Copy link
Contributor

also includes version bumps of k8s.io/api and k8s.io/apimachinery to release-1.10 with a new vendor of github.com/json-iterator/go due to an issue (kubernetes/apimachinery#46) with client-go v7.0

addresses #110

Copy link
Contributor

@anguslees anguslees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I note this leaves a few unused libraries - and it looks like you added the roots of the k8s modules rather than specific packages (common govendor UX issue).

Can you run govendor remove +m +u over this? Then lgtm.

also includes version bumps of k8s.io/api and k8s.io/apimachinery to release-1.10 with a new vendor of github.com/json-iterator/go due to an issue (kubernetes/apimachinery#46) with client-go v7.0

addresses bitnami-labs#110
@jipperinbham
Copy link
Contributor Author

I think I did the govendor remove properly but it's been a while since I've used govendor. Also went ahead and squashed the commits down in case it's ready to merge.

@anguslees
Copy link
Contributor

Perfect, thanks again!

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 13, 2018

👎 Rejected by too few approved reviews

@anguslees
Copy link
Contributor

 Rejected by too few approved reviews

Oops, try again:

bors r+

bors bot added a commit that referenced this pull request Nov 13, 2018
126: client-go version bump to release-7.0 r=anguslees a=jipperinbham

also includes version bumps of k8s.io/api and k8s.io/apimachinery to release-1.10 with a new vendor of github.com/json-iterator/go due to an issue (kubernetes/apimachinery#46) with client-go v7.0

addresses #110 

Co-authored-by: JP Phillips <[email protected]>
@bors
Copy link
Contributor

bors bot commented Nov 13, 2018

Build succeeded

@bors bors bot merged commit 51aaa46 into bitnami-labs:master Nov 13, 2018
@jipperinbham jipperinbham deleted the client-go-update branch November 13, 2018 16:05
@ghost
Copy link

ghost commented Dec 19, 2018

🕺

@mkmik mkmik added this to the v0.8.0 milestone Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants