fix: explicitly set resourceFieldRef.divisor #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the helm chart the divisor is not set and kubernetes mutates the Deployments to "0" which is the same as "1". Signed-off-by: Jan <[email protected]>
Jaydee94
changed the title
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
|
Hey, can you consider to accept this change to the helm chart? This would help us so that our Argocd does not show out of sync. Best Regards :) |
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
|
Due to the lack of activity in the last 7 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary. |
alvneiayu
added
backlog
agarcia-oss
approved these changes
Jan 16, 2025
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jan 28, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [bitnami-labs/sealed-secrets](https://github.com/bitnami-labs/sealed-secrets) | minor | `v0.27.3` -> `v0.28.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>bitnami-labs/sealed-secrets (bitnami-labs/sealed-secrets)</summary> ### [`v0.28.0`](https://github.com/bitnami-labs/sealed-secrets/blob/HEAD/RELEASE-NOTES.md#v0280) [Compare Source](bitnami-labs/sealed-secrets@v0.27.3...v0.28.0) - fix: explicitly set resourceFieldRef.divisor ([#​1655](bitnami-labs/sealed-secrets#1655)) - Fix deprecated functions for bumping client-go ([#​1667](bitnami-labs/sealed-secrets#1667)) - Bump github.com/onsi/ginkgo/v2 from 2.22.1 to 2.22.2 ([#​1670](bitnami-labs/sealed-secrets#1670)) - Bump golang.org/x/crypto from 0.31.0 to 0.32.0 ([#​1671](bitnami-labs/sealed-secrets#1671)) - Bump github.com/onsi/gomega from 1.36.1 to 1.36.2 ([#​1669](bitnami-labs/sealed-secrets#1669)) - Bump github.com/onsi/ginkgo/v2 from 2.22.0 to 2.22.1 ([#​1668](bitnami-labs/sealed-secrets#1668)) - Bump github.com/onsi/gomega from 1.36.0 to 1.36.1 ([#​1664](bitnami-labs/sealed-secrets#1664)) - Bump golang.org/x/crypto from 0.30.0 to 0.31.0 ([#​1659](bitnami-labs/sealed-secrets#1659)) - Bump golang.org/x/crypto from 0.29.0 to 0.30.0 ([#​1657](bitnami-labs/sealed-secrets#1657)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMzcuMSIsInVwZGF0ZWRJblZlciI6IjM5LjEzNy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
In the helm chart the divisor is not set and kubernetes mutates the Deployments to "0" which is the same as "1".
Benefits
When deploying with ArgoCD the application will not be displayed as "OutOfSync"
Possible drawbacks