Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/postgresql] value to configure posgres_exporter collectors #21162

Merged
merged 1 commit into from
Nov 22, 2023
Merged

[bitnami/postgresql] value to configure posgres_exporter collectors #21162

merged 1 commit into from
Nov 22, 2023

Conversation

jouve
Copy link
Contributor

@jouve jouve commented Nov 21, 2023 •
edited
Loading

Description of the change

add a new option to configure collectors of postgres exporter

Benefits

allows to switch collectors on/off

for example, to disable wal collector for #20247 or enable collectors that are disabled by default

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added the triage Triage is needed label Nov 21, 2023
@carrodher carrodher added the verify Execute verification workflow for these changes label Nov 22, 2023
@github-actions github-actions bot added in-progress and removed triage Triage is needed labels Nov 22, 2023
@bitnami-bot bitnami-bot removed the request for review from javsalgar November 22, 2023 08:24
@bitnami-bot bitnami-bot requested a review from juan131 November 22, 2023 08:24
juan131
juan131 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this contribution, LGTM

@juan131 juan131 merged commit 0ba581c into bitnami:main Nov 22, 2023
@jouve jouve mentioned this pull request Dec 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan131 juan131 juan131 approved these changes

Assignees

@juan131 juan131

Labels
postgresql solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jouve @juan131 @javsalgar @carrodher