Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/postgresql] collect metrics as postgres user #29201

Merged

Conversation

tbalzer
Copy link
Contributor

@tbalzer tbalzer commented Sep 4, 2024

Description of the change

This change intends to change the credentials used by the metrics container to those of the postgres user, regardless of whether a custom user is also created or not.

Benefits

The postgres user has administrative privileges which allows this user to actually monitor all databases correctly, avoiding issues with permissions like in #29156 and #20247

Possible drawbacks

metrics container has full administrative privileges, but this is also the case if no custom user is created. Using the custom user for this however does not seem to be the right approach. It could be improved further by using a dedicated monitoring/metrics user.

Applicable issues

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Bitnami Containers <[email protected]>
@github-actions github-actions bot removed the triage Triage is needed label Sep 5, 2024
@github-actions github-actions bot removed the request for review from javsalgar September 5, 2024 07:13
@github-actions github-actions bot requested a review from jotamartos September 5, 2024 07:13
@tbalzer
Copy link
Contributor Author

tbalzer commented Sep 9, 2024

Hey @jotamartos , what do you think regarding these changes?

@tbalzer tbalzer force-pushed the postgresql-collect-metrics-as-postgres-user branch from d6deed7 to 5d63d1a Compare September 12, 2024 10:59
Signed-off-by: Bitnami Containers <[email protected]>
Copy link
Contributor

@jotamartos jotamartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepting this as this is the default approach when no custom user is defined. Ideally, we should create a separate user for the metrics, but that's something that can be done in a different contribution.

@jotamartos jotamartos merged commit 7240870 into bitnami:main Sep 13, 2024
9 checks passed
bartramakers pushed a commit to bartramakers/bitnami-charts that referenced this pull request Sep 18, 2024
* [bitnami/postgresql] collect metrics as postgres user

Signed-off-by: Tim Balzer <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

* [bitnami/postgresql] bump to 15.5.29

Signed-off-by: Tim Balzer <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Tim Balzer <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Co-authored-by: Bitnami Containers <[email protected]>
mike12806 pushed a commit to mike12806/charts that referenced this pull request Oct 30, 2024
* [bitnami/postgresql] collect metrics as postgres user

Signed-off-by: Tim Balzer <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

* [bitnami/postgresql] bump to 15.5.29

Signed-off-by: Tim Balzer <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Tim Balzer <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Co-authored-by: Bitnami Containers <[email protected]>
Signed-off-by: Michael Faherty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants