-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/postgresql] collect metrics as postgres user #29201
Merged
jotamartos
merged 7 commits into
bitnami:main
from
ExB-Group:postgresql-collect-metrics-as-postgres-user
Sep 13, 2024
Merged
[bitnami/postgresql] collect metrics as postgres user #29201
jotamartos
merged 7 commits into
bitnami:main
from
ExB-Group:postgresql-collect-metrics-as-postgres-user
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Balzer <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Tim Balzer <[email protected]>
Signed-off-by: Tim Balzer <[email protected]>
Hey @jotamartos , what do you think regarding these changes? |
Signed-off-by: Tim Balzer <[email protected]>
d6deed7
to
5d63d1a
Compare
Signed-off-by: Bitnami Containers <[email protected]>
jotamartos
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accepting this as this is the default approach when no custom user is defined. Ideally, we should create a separate user for the metrics, but that's something that can be done in a different contribution.
bartramakers
pushed a commit
to bartramakers/bitnami-charts
that referenced
this pull request
Sep 18, 2024
* [bitnami/postgresql] collect metrics as postgres user Signed-off-by: Tim Balzer <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * [bitnami/postgresql] bump to 15.5.29 Signed-off-by: Tim Balzer <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Tim Balzer <[email protected]> Signed-off-by: Bitnami Containers <[email protected]> Co-authored-by: Bitnami Containers <[email protected]>
mike12806
pushed a commit
to mike12806/charts
that referenced
this pull request
Oct 30, 2024
* [bitnami/postgresql] collect metrics as postgres user Signed-off-by: Tim Balzer <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * [bitnami/postgresql] bump to 15.5.29 Signed-off-by: Tim Balzer <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Tim Balzer <[email protected]> Signed-off-by: Bitnami Containers <[email protected]> Co-authored-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This change intends to change the credentials used by the
metrics
container to those of thepostgres
user, regardless of whether a custom user is also created or not.Benefits
The
postgres
user has administrative privileges which allows this user to actually monitor all databases correctly, avoiding issues with permissions like in #29156 and #20247Possible drawbacks
metrics
container has full administrative privileges, but this is also the case if no custom user is created. Using the custom user for this however does not seem to be the right approach. It could be improved further by using a dedicated monitoring/metrics user.Applicable issues
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm