Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/chainloop] Add support for usePasswordFiles #32081

Closed
wants to merge 7 commits into from

Conversation

migruiz4
Copy link
Member

Description of the change

Adds support for usePasswordFiles and enables it by default.

Benefits

With this change, the chart will mount the secrets as files by default instead of directly setting them into environment variables.

Variables are renamed with the _FILE suffix and point to the mounted secret file.

Possible drawbacks

None

Applicable issues

None

Additional information

N/A

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added chainloop verify Execute verification workflow for these changes bitnami labels Feb 20, 2025
@github-actions github-actions bot requested a review from dgomezleon February 20, 2025 16:01
bitnami-bot and others added 6 commits February 20, 2025 16:03
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
@migruiz4
Copy link
Member Author

Please ignore this PR.

The only password used in the bitnami/chainloop chart is the CONNECTION_STRING variable used in the control-plane-migrations container.

That container uses scratch (no shell) so it is not possible to use $(< to load the env variable from a file.
The binary atlas doesn't support loading the URL from a file, so we need to skip this one.

@migruiz4 migruiz4 closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami chainloop solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants