Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/redis] Support retrieving Redis ACL user passwords from Kubernetes Secrets #32137

Closed
wants to merge 0 commits into from

Conversation

emahdij
Copy link
Contributor

@emahdij emahdij commented Feb 23, 2025

Description of the change

  • Introduced auth.acl.userSecret for specifying the secret containing user credentials.
  • Added helper function common.secrets.get to fetch user credentials from a Secret.
  • Updated Redis ACL user configuration to prioritize secrets over plain-text passwords.
  • Ensured backward compatibility by falling back to .password when no secret is found.

Benefits

  • Allows passwords to be managed in Kubernetes secrets instead of being hardcoded in values.yaml.

Possible drawbacks

  • None. The change is backward compatible, and previous users can continue using the chart without any issues.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added redis triage Triage is needed labels Feb 23, 2025
@github-actions github-actions bot requested a review from carrodher February 23, 2025 17:51
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Feb 24, 2025
@github-actions github-actions bot removed the triage Triage is needed label Feb 24, 2025
@github-actions github-actions bot removed the request for review from carrodher February 24, 2025 07:53
@github-actions github-actions bot requested a review from gongomgra February 24, 2025 07:53
@emahdij emahdij closed this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redis solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants