Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/harbor] MAJOR change - bump Redis subchart #4054

Merged
merged 3 commits into from
Oct 20, 2020

Conversation

joancafom
Copy link
Contributor

@joancafom joancafom commented Oct 19, 2020

Description of the change
This PR bumps Harbor major version since its dependency (Redis) bumped the major version including breaking changes. More info at #3658

Additionally, apiVersion helper was changed to use the common library so as to match other charts.

Benefits

Up-to-date subcomponents, standardization.

Possible drawbacks

None

Applicable issues

NA

Additional information
This chart does not use sentinel so, no breaking changes should be expected.

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [bitnami/chart])

⚠️ Keep in mind that if you want to make changes to the kubeapps chart, please implement them in the kubeapps repository. This is only a synchronized mirror.

Copy link
Contributor

@miguelaeh miguelaeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!
LGTM!

@joancafom joancafom merged commit 1295ff1 into bitnami:master Oct 20, 2020
@joancafom joancafom deleted the harbor-subchart-major branch October 20, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants