Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/discourse] Bump subcharts and common helpers #4087

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

joancafom
Copy link
Contributor

Signed-off-by: joancafom [email protected]

Description of the change

This PR updates PostgreSQL and Redis subchart to the new major versions. The former includes breaking changes that affect this chart. More info at #3021 and #3658 respectively.

Also, took the chance to implement some standardizations using bitnami/common library chart, such as: password validation on upgrade, simplification of _helper.tpl & use of standard labels (non-breaking change, this chart already included them but now using bitnami/common approach)

Benefits

Standardization, up-to-date subcomponents

Possible drawbacks

Breaking backwards compatibility

Applicable issues

NA

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [bitnami/chart])
  • If the chart contains a values-production.yaml apart from values.yaml, ensure that you implement the changes in both files

⚠️ Keep in mind that if you want to make changes to the kubeapps chart, please implement them in the kubeapps repository. This is only a synchronized mirror.

Copy link
Contributor

@miguelaeh miguelaeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the PR!!!
Please take a look at my comments.

Copy link
Contributor

@miguelaeh miguelaeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments similar to the previous one

Copy link
Contributor

@miguelaeh miguelaeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joancafom joancafom merged commit 842d972 into bitnami:master Oct 27, 2020
@joancafom joancafom deleted the discourse-major-subchart branch October 27, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants