Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache bust files on test run #60

Closed
phillipskevin opened this issue Oct 23, 2015 · 2 comments
Closed

Cache bust files on test run #60

phillipskevin opened this issue Oct 23, 2015 · 2 comments

Comments

@phillipskevin
Copy link
Contributor

Files are not re-requested if they are cached by the browser (obviously).

The issue I ran into now is that if I enable coverage testee test/qunit-tests.html --coverage and then run again with it disabled testee test/qunit-tests.html -c testee.json, coverage data is still reported because the files were instrumented on the previous test run. This also happens the other way where coverage data does not show up because a previous run had coverage disabled.

One solution is to do something similar to what Karma does and add a cache buster to the URL. If I remember correctly, Karma always adds a parameter like ?=234242411542 to each JS file requested.

@daffl
Copy link
Contributor

daffl commented Oct 23, 2015

We can't add parameters because that would mean rewriting every link that we find. Karma has more control over it because it runs it in its own environment. The best solution is probably to get https://github.com/ekryski/launchpad to handle profiles and create a new temporary one on every run (see bitovi/launchpad#11).

@andrejewski
Copy link
Contributor

Browser caching issues were addressed by #131. If these problems persist, this issue can be reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants