Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent browser caching #131

Merged
merged 2 commits into from
May 11, 2017
Merged

Prevent browser caching #131

merged 2 commits into from
May 11, 2017

Conversation

andrejewski
Copy link
Contributor

@andrejewski andrejewski commented May 9, 2017

See #106. Trying to prevent browser caching. How to test this (other than the test can run all at once now)?

@andrejewski andrejewski changed the title Prevent browser caching {WIP} Prevent browser caching May 9, 2017
@andrejewski andrejewski requested a review from phillipskevin May 9, 2017 20:12
@matthewp
Copy link
Contributor

👍

@phillipskevin
Copy link
Contributor

@andrejewski do the tests fail if you remove the nocache function?

@andrejewski
Copy link
Contributor Author

@phillipskevin I will try that. Right now I'm thinking I need to reorder the tests, in the build the Coverage tests run first which I don't think will error for the normal tests, I want to flip them around.

@phillipskevin
Copy link
Contributor

Yeah, you can just rename the coverage test file to try it out.

@andrejewski
Copy link
Contributor Author

@phillipskevin re-ordering the files still passes based on the new build.

@andrejewski andrejewski merged commit 3cb4ab2 into master May 11, 2017
@andrejewski andrejewski deleted the prevent-caching branch May 11, 2017 14:30
This was referenced May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants