Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creating a tx with more outputs than inputs fails with a misleading error #1236

Closed
maraoz opened this issue May 15, 2015 · 5 comments · Fixed by #1248
Closed

creating a tx with more outputs than inputs fails with a misleading error #1236

maraoz opened this issue May 15, 2015 · 5 comments · Fixed by #1248
Assignees

Comments

@maraoz
Copy link
Contributor

maraoz commented May 15, 2015

Uncaught bitcore.ErrorTransactionFeeErrorDifferent: Unspent value is different from specified fee: Unspent value is -33338 but specified fee is 10000 Use Transaction#uncheckedSerialize if you want to skip security checks. See http://bitcore.io/guide/transaction.html#Serialization for more info.

@braydonf braydonf added the ready label May 15, 2015
@braydonf
Copy link
Contributor

We may need to do the output greater than input check (https://github.com/bitpay/bitcore/blob/master/lib/transaction/transaction.js#L222) before the fee is different check?

@dskloet
Copy link
Contributor

dskloet commented May 16, 2015

That error can probably go before all the other ones. I can have a look when #1226 is merged.

@maraoz
Copy link
Contributor Author

maraoz commented May 16, 2015

Yes, that's the same solution we discussed with @eordano

On Sat, May 16, 2015, 12:10 dskloet [email protected] wrote:

That error can probably go before all the other ones. I can have a look
when #1226 #1226 is merged.

Reply to this email directly or view it on GitHub
#1236 (comment).

@dskloet
Copy link
Contributor

dskloet commented May 18, 2015

What about missing signatures? Should that check go before fee errors and dust outputs as well?

@dskloet
Copy link
Contributor

dskloet commented May 18, 2015

I created pull request #1241.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants