Fixed script.isPublicKeyHashIn bug with variable length signatures. #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
braydonf
commented
May 9, 2015
braydonf
commented
- DER encoded signatures have a max length of 72 bytes, however a minimum size isn't defined.
- R and S values can have arbitrary lengths
- For more information: https://github.com/bitcoin/bips/blob/master/bip-0062.mediawiki#der-encoding
braydonf
force-pushed
the
bug/is-fully-signed
branch
from
d42ab32 to
acef641
Compare
- DER encoded signatures have a max length of 72 bytes, however a minimum size isn't defined. - R and S values can have arbitrary lengths - For more information: https://github.com/bitcoin/bips/blob/master/bip-0062.mediawiki#der-encoding
braydonf
force-pushed
the
bug/is-fully-signed
branch
from
acef641 to
d8e9068
Compare
|
ACK. We should maybe add something like |
|
We should add some fixtures for this particular case; #1221 for tracking. Otherwise, nice work. |
martindale
added a commit
that referenced
this pull request
May 11, 2015
Fixed script.isPublicKeyHashIn bug with variable length signatures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.