Fixes bug with misleading error with getSerializationError. Closes #1236#1248

Merged

pnagurny merged 8 commits intobitpay:masterfrom braydonf:bug/misleading-error

May 26, 2015

+100-86

Commits on May 24, 2015

When checking for transaction serialization errors, check the output amount before checking fee errors. Added a test for it and also improved buildSkipTest by specifying which error to expect and u…

dskloet
authored and
Braydon Fuller
committed
Expect the correct error to be thrown.

dskloet
authored and
Braydon Fuller
committed
Put )); on a separate line.

dskloet
authored and
Braydon Fuller
committed
When disableMoreOutputThanInput is set for getSerializationError, also disable the fee checks as the concept of a fee is meaningless when unspent output value is negative. This also allows for remo…

dskloet
authored and
Braydon Fuller
committed
Ignore fee error when unspent output is actually negative, rather than already when the check for negative unspent output is disabled.

dskloet
authored and
Braydon Fuller
committed
Call getUnspentValue() only once in getSerializationError().

dskloet
authored and
Braydon Fuller
committed
Refactored transaction.getSerializationError to be more concise.
Braydon Fuller
committed
Added test for null input for transaction.verify()
Braydon Fuller
committed