Restore error when trying to derive a hardened path with HDPublicKey. #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
braydonf
commented
Aug 14, 2015
braydonf
commented
- Restores InvalidIndexCantDeriveHardened error in spec
- Passes hardened argument in HDPublicKey (in case the feature is attempted to be used similarly to HDPrivateKey)
- Fixes undefined error with InvalidLength
- Fixes tests to check for the error type
- Various formatting cleanup improvements
- Restores InvalidIndexCantDeriveHardened error in spec - Passes hardened argument in HDPublicKey (in case the feature is attempted to be used similarly to HDPrivateKey) - Fixes undefined error with InvalidLength - Fixes tests to check for the error type - Various formatting cleanup improvements
braydonf
force-pushed
the
hdpubkey-hardened-error
branch
from
720b821 to
809ff14
Compare
braydonf
changed the title
|
LGTM |
pnagurny
added a commit
that referenced
this pull request
Aug 18, 2015
Restore error when trying to derive a hardened path with HDPublicKey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.