Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/google maps key #100

Merged
merged 12 commits into from
Jun 21, 2022
Merged

Conversation

cnguyen812
Copy link
Contributor

@cnguyen812 cnguyen812 commented Jun 10, 2022

  • added support for GOOGLE_MAPS_API_KEY in .env files and replacement scripts
  • updated Android build script to set and reset .env replacement scripts as pre- and post-build scripts
  • added checks so replacement doesn't occur if env value is falsey
  • updated script command from android:build:release to build:android:release for consistency

Key scripts:

  • yarn set:dev/yarn set:prod to set the dev/prod stuff, mainly inject the env variables into the appropriate files
  • yarn reset:dev/yarn reset:prod to reset the dev/prod stuff back to commit state
  • yarn build:android:release/yarn build:android:debug builds the android apk with the dev/prod keys injected but also resets them afterward

@JohnathanWhite JohnathanWhite merged commit bddde13 into bitpay:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants