Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: backup encrypt pass request #1014

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

Gamboster
Copy link
Collaborator

Steps to reproduce the error:

  1. Go to Settings -> Wallets & Keys -> (Select a Key) -> Enable: "Request Encrypt Password" -> Enter a new password
  2. Go to Backup -> Write Down Recovery Phrase -> Enter your password
  3. Go back and Disable "Request Encrypt Password"
  4. Enter again in Backup -> Write Down Recovery Phrase
    At this point the encrypt password will be requested again despite having been previously disabled. (Entering any password will be considered valid and you will enter the backup view).

gabrielbazan7
gabrielbazan7 previously approved these changes Dec 20, 2023
Copy link
Collaborator

@gabrielbazan7 gabrielbazan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

cmgustavo
cmgustavo previously approved these changes Dec 26, 2023
Copy link
Member

@cmgustavo cmgustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@Gamboster Gamboster dismissed stale reviews from cmgustavo and gabrielbazan7 via 4759de3 January 8, 2024 17:52
@Gamboster Gamboster force-pushed the fix/backupEncryptRequest branch from 7829b3b to 4759de3 Compare January 8, 2024 17:52
@JohnathanWhite JohnathanWhite merged commit 5c565b5 into bitpay:master Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants