Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] copy to clipboard information view #103

Merged

Conversation

gabrielbazan7
Copy link
Collaborator

No description provided.

@lanchana lanchana self-requested a review June 15, 2022 15:02
@lanchana
Copy link
Contributor

can we display the icon in this style(copy transaction id from details) for derivation path and address type.
https://user-images.githubusercontent.com/23244595/173863845-da451ac8-1fc2-4754-bb51-4899bf50653c.mov

For wallet Id icon right side of the text and right side for copayers too but leave some default space for icon to avoid text jump on copied.

@gabrielbazan7 gabrielbazan7 force-pushed the feat/information-copytoclipboard branch 2 times, most recently from 69c53ad to ec31674 Compare June 15, 2022 18:49
@lanchana
Copy link
Contributor

merge conflicts 🤕

@gabrielbazan7 gabrielbazan7 force-pushed the feat/information-copytoclipboard branch 2 times, most recently from 843144e to d361f3d Compare June 17, 2022 13:19
@lanchana
Copy link
Contributor

I think we should keep the current styles(single row for address and balance) and add the copied icon next to address.
Screen Shot 2022-06-17 at 1 39 22 PM
Screen Shot 2022-06-17 at 1 42 26 PM

@gabrielbazan7 gabrielbazan7 force-pushed the feat/information-copytoclipboard branch from d361f3d to 189fc7e Compare June 21, 2022 14:18
@gabrielbazan7 gabrielbazan7 force-pushed the feat/information-copytoclipboard branch from 189fc7e to 69c84d1 Compare June 21, 2022 19:09
Copy link
Contributor

@lanchana lanchana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JohnathanWhite JohnathanWhite merged commit 12ce2fd into bitpay:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants