Feat: Sell crypto - Moonpay #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gamboster
force-pushed
the
feat/sellCrypto-moonpay
branch
3 times, most recently
from
9c00e32 to
f647ac5
Compare
Gamboster
force-pushed
the
feat/sellCrypto-moonpay
branch
from
f647ac5 to
e8ac4ab
Compare
Gamboster
changed the title
JohnathanWhite
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitcore PR required for this: bitpay/bitcore#3700
Needs:
yarn installto update BWCTo test this feature we can use an ETH test wallet.
Moonpay stopped supporting ETH Goerli, and started using ETH Sepolia.
Steps and workaround to test the complete flow in sandbox:
Create an ETH Goerli wallet in bitpay app, add funds. You can use this faucet: https://goerli-faucet.pk910.de/
For now we can use another wallet that allows ETH Sepolia like Metamask: Go to "Select a network" -> Choose "Sepolia Test Network" -> "Receive" and load some Sepolia funds. You can use this faucet: https://sepolia-faucet.pk910.de/
In the app: Go to Sell Crypto -> Select the ETH Goerli wallet -> Debit card -> enter 0.1 ETH as the amount to sell. -> Continue
The browser will direct you to the Moonpay checkout page, where you will create an account (for tests you can use a public email as a mailinator). Or you will log in if you already have an account.
Accept the order -> Pay with Bitpay App -> You will be redirected to the app again.
Once in the app, you will be redirected to Confirm view: Review the TX, pat the checkbox to accept Terms, and you will be able to send the 0.1 ETH Goerli. Then from Metamask, you can send 0.1 ETH Sepolia to the "Deposit Address" that is present in Confirm View.
Once the funds have been sent you will see the "Success screen" and will be redirected to Moonpay's Sell history, where you can see the details of the order.
Things to keep in mind:
For US users, Moonpay works with fixed amounts so it can be expected that the amount to be received will be the one previously agreed on the Summary page.
For non-US users, Moonpay works with floating amounts so at the time of confirmation we ask for the most up-to-date quote.