Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/init optimizations #131

Merged
merged 6 commits into from
Jun 21, 2022
Merged

Fix/init optimizations #131

merged 6 commits into from
Jun 21, 2022

Conversation

cnguyen812
Copy link
Contributor

Focused mainly on reducing renders on the settings tab, cut a few seconds off the startup time

  • stopped awaiting Dosh init and have it run asynchronously
  • total key balance status was updating the store one at a time, made changes to update all keys in one store update
  • memoized SettingsList components to minimize unnecessary downstream renders

@cnguyen812 cnguyen812 force-pushed the fix/init-optimizations branch from 2568f51 to f21c799 Compare June 21, 2022 23:01
@JohnathanWhite JohnathanWhite merged commit 9ebfd0c into bitpay:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnathanWhite JohnathanWhite JohnathanWhite approved these changes

@cmgustavo cmgustavo Awaiting requested review from cmgustavo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cnguyen812 @JohnathanWhite