Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: PayPal and Venmo added as Payment method opts #1483

Merged
merged 6 commits into from
Nov 29, 2024
Merged

Feat: PayPal and Venmo added as Payment method opts #1483

merged 6 commits into from
Nov 29, 2024

Conversation

Gamboster
Copy link
Collaborator

In this PR:

  • PayPal and Venmo added as supported paymentMethods/withdrawalMethods for Moonpay (Buy/Sell)
  • New order for paymentMethods/withdrawalMethods in the selector
  • Ref: PaymentMethod models renamed to WithdrawalMethod in sell crypto
  • Fix: Fixed an issue where Sell crypto for EU countries only allows EUR as fiatCurrency
  • Fix: Small UI fix for Keys selector when list is large (Bottom key not fully displayed)
  • Fix: Now paymentMethod is added to moonpay-url so that it is preselected when reaching their web checkout.

cmgustavo
cmgustavo approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@cmgustavo cmgustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK!

@JohnathanWhite JohnathanWhite merged commit f8c9bb4 into bitpay:master Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmgustavo cmgustavo cmgustavo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gamboster @cmgustavo @JohnathanWhite