Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/pin modal freezing #149

Merged
merged 5 commits into from
Jun 27, 2022
Merged

Fix/pin modal freezing #149

merged 5 commits into from
Jun 27, 2022

Conversation

cnguyen812
Copy link
Contributor

Fixed app freezing (iOS) when setting Lock:

  • update PinModal to use BaseModal to avoid timing issue with sheet modals
  • added sleeps for setting biometric in case of error until we find aa way around opening multiple sheet modals
  • added better error handling if biometric error

@JohnathanWhite JohnathanWhite merged commit 667df2a into bitpay:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnathanWhite JohnathanWhite JohnathanWhite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cnguyen812 @JohnathanWhite