Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update notifications #185

Merged
merged 9 commits into from
Jul 19, 2022
Merged

Update notifications #185

merged 9 commits into from
Jul 19, 2022

Conversation

lanchana
Copy link
Contributor

@lanchana lanchana commented Jul 5, 2022 •
edited
Loading

  • push notifications
  • email notifications

@lanchana lanchana marked this pull request as draft July 5, 2022 18:52
@lanchana lanchana marked this pull request as ready for review July 6, 2022 18:42
@lanchana lanchana requested review from cmgustavo and cnguyen812 July 6, 2022 18:42
@gabrielbazan7
Copy link
Collaborator

Nice pr. Onboarding (Notifications.txs) need some changes too.

@lanchana
Copy link
Contributor Author

Nice pr. Onboarding (Notifications.txs) need some changes too.

Good catch! updated it, ty!

@JohnathanWhite
Copy link
Collaborator

just talked to marketing - we are going to hold on this one it will be in the next release after we go live 14.5

@JohnathanWhite JohnathanWhite merged commit ae085ad into bitpay:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnathanWhite JohnathanWhite JohnathanWhite approved these changes

@cmgustavo cmgustavo Awaiting requested review from cmgustavo

@cnguyen812 cnguyen812 Awaiting requested review from cnguyen812

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lanchana @gabrielbazan7 @JohnathanWhite