Feat/refactor amount screen components #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nent to keep a consistent parameter list
|
Nice refactor! This PR needs rebase. |
|
You can also delete /navigation/wallet/components/amountModal.tsx file and use the new amountModal component for the select inputs feature. ( select inputs feature was made after you send this PR ) |
gabrielbazan7
requested changes
Jul 25, 2022
cnguyen812
force-pushed
the
feat/refactor-screen-components
branch
from
db84b8a to
ffdfce3
Compare
…tor-screen-components
|
Other amountModal replaced, merge conflicts fixed, ready for re-review |
|
merge conflicts |
…tor-screen-components
cnguyen812
dismissed stale reviews from Gamboster and gabrielbazan7
via
3beef86
…tor-screen-components
gabrielbazan7
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Amountscreen component had to dynamically handle 2 argument lists depending on usage as a screen or standalone component.Refactored it into a standalone component with explicit event handler props, also created an AmountModal component to replace the duplicates for buy/swap/coinbase