Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: sum coinbase balance to Portfolio Balance #208

Merged

Conversation

cmgustavo
Copy link
Member

No description provided.

const defaultAltCurrency = useAppSelector(({APP}) => APP.defaultAltCurrency);

// Sum only if same currency
var totalBalance: number = portfolioBalance.current;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we change this to be let

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. thanks!

@cmgustavo cmgustavo force-pushed the feat/coinbase-total-balance-01 branch from b9ba400 to 0ca8d65 Compare July 12, 2022 15:18
Copy link
Collaborator

@Gamboster Gamboster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼
tested with different fiat currencies

Copy link
Collaborator

@rastajpa rastajpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Collaborator

@msalcala11 msalcala11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnathanWhite JohnathanWhite merged commit 1ec3a81 into bitpay:master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants