Fix home memo cards language update #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanchana
force-pushed
the
fix-home-card-language-update
branch
2 times, most recently
from
d5d0de4 to
e6f1eeb
Compare
lanchana
force-pushed
the
fix-home-card-language-update
branch
from
e6f1eeb to
e1f9a22
Compare
cnguyen812
reviewed
Jul 14, 2022
| @@ -184,7 +184,7 @@ const Referral = ({}) => { | |||
|
|
|||
| const getStatus = (status: string, expiration: number) => { | |||
| return status === 'pending' && currentDate >= expiration | |||
| ? 'Expired' | |||
| ? t('Expired') | |||
| : status.charAt(0).toUpperCase() + status.slice(1); | |||
There was a problem hiding this comment.
Is status enumerated somewhere? If so we should create a map and map each known status to a translated value
| @@ -5,38 +5,47 @@ interface ItemProps { | |||
|
|
|||
| export const LanguageList: Array<ItemProps> = [ | |||
| { | |||
| // t('Dutch') | |||
cnguyen812
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.