Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gift card improvements #244

Merged
merged 2 commits into from
Jul 16, 2022
Merged

Gift card improvements #244

merged 2 commits into from
Jul 16, 2022

Conversation

msalcala11
Copy link
Collaborator

  1. Ensures that only a single tap is required to navigate to a gift card search result when the keyboard is open (currently two taps are required, with the first tap closing the keyboard)
  2. Fixes a wonky stack reset that happens when purchasing a gift card with Coinbase by ensuring that the Coinbase 2fa screen is part of the GiftCardStack so that all screens in the checkout flow are all part of the same stack and therefore dismissed simultaneously

@lanchana lanchana self-requested a review July 15, 2022 19:25
lanchana
lanchana approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@lanchana lanchana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JohnathanWhite JohnathanWhite merged commit eebd091 into bitpay:master Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanchana lanchana lanchana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msalcala11 @lanchana @JohnathanWhite