Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll to top when tapping on the active tab. #247

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

lanchana
Copy link
Contributor

No description provided.

@lanchana lanchana force-pushed the tab-scroll-to-top branch from 8c06bc5 to 74a6aa7 Compare July 18, 2022 15:47
@cmgustavo
Copy link
Member

IMO I prefer to keep the position where I left the "cursor". It helps for example when you are checking balance before buy a gift card from last merchant in the list

@gabrielbazan7
Copy link
Collaborator

I agree with Gustavo. The way to do this is double tap on the tab icon to scroll to top.

@lanchana
Copy link
Contributor Author

Scroll to top:

  • double tap when navigating between diff tabs
  • single tap on active tab. ex: currently on shop tab and single tap on shop tab will scroll to top

Copy link
Member

@cmgustavo cmgustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼 Tested on iOS

@JohnathanWhite JohnathanWhite merged commit 9796cf2 into bitpay:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants