Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: prevent swipe back action returns to Home tab #351

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Fix: prevent swipe back action returns to Home tab #351

merged 3 commits into from
Sep 7, 2022

Conversation

cmgustavo
Copy link
Member

@cmgustavo cmgustavo commented Aug 11, 2022 •
edited
Loading

  • Go to Create -> New Key -> Swipe back (it goes to Home instead Select an option screen)

After fix:

  • Swipe back is disabled on the Select Currencies screen.

@cmgustavo cmgustavo requested a review from rastajpa August 12, 2022 17:20
@cmgustavo cmgustavo requested review from gabrielbazan7 and removed request for rastajpa September 7, 2022 14:08
gabrielbazan7
gabrielbazan7 approved these changes Sep 7, 2022
View reviewed changes
Copy link
Collaborator

@gabrielbazan7 gabrielbazan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@JohnathanWhite JohnathanWhite merged commit 95859f8 into bitpay:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielbazan7 gabrielbazan7 gabrielbazan7 approved these changes

@JohnathanWhite JohnathanWhite JohnathanWhite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmgustavo @gabrielbazan7 @JohnathanWhite