Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deferred key import improvements #404

Merged
merged 9 commits into from
Sep 16, 2022
Merged

Deferred key import improvements #404

merged 9 commits into from
Sep 16, 2022

Conversation

lanchana
Copy link
Contributor

@lanchana lanchana commented Sep 12, 2022 •
edited
Loading

  • fix key flash
  • update placeholder colors
  • add box shadow

@lanchana lanchana marked this pull request as draft September 12, 2022 22:01
@lanchana lanchana force-pushed the deferred-import-improvements branch from bb04eb4 to 793c6cd Compare September 14, 2022 15:58
@lanchana lanchana marked this pull request as ready for review September 14, 2022 16:01
@lanchana lanchana changed the title WIP: Deferred key improvements Deferred key import improvements Sep 14, 2022
gabrielbazan7
gabrielbazan7 approved these changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@gabrielbazan7 gabrielbazan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK!

@JohnathanWhite JohnathanWhite merged commit aa17dd2 into bitpay:master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielbazan7 gabrielbazan7 gabrielbazan7 approved these changes

@JohnathanWhite JohnathanWhite Awaiting requested review from JohnathanWhite

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lanchana @gabrielbazan7 @JohnathanWhite