Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] simplify adding new chains #423

Merged
merged 13 commits into from
Oct 2, 2022
Merged

[REF] simplify adding new chains #423

merged 13 commits into from
Oct 2, 2022

Conversation

gabrielbazan7
Copy link
Collaborator

@gabrielbazan7 gabrielbazan7 commented Sep 23, 2022 •
edited
Loading

  • support chain in currency utils
  • add chain to contacts
  • handle new token rates format -> (usdc_e, busd_e)
  • handle differents coingecko blockchain networks
  • adding badgeImg property to all erc20 tokens and chain to all wallets obj
  • REF supported coins and tokens constants to better handle new evm chains
  • refresh wallet obj in transform function to make sure chain (or other properties) is not missing
  • use chain, network and currencyAbbreviation instead of credentials.chain/network/coin
  • handle chain in incomingData
  • chain and currencyAbbreviation always in lowercase
  • add chain suffix to token names

@gabrielbazan7 gabrielbazan7 force-pushed the ref/new-chains branch 17 times, most recently from 29f9623 to a76b8d8 Compare September 27, 2022 23:30
Gamboster
Gamboster previously approved these changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@Gamboster Gamboster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Huge work 👏🏼

cmgustavo
cmgustavo previously approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@cmgustavo cmgustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work! 🚀

@gabrielbazan7 gabrielbazan7 dismissed stale reviews from cmgustavo and Gamboster via 028079a September 29, 2022 18:08
@lanchana
Copy link
Contributor

Global select Send is not working

Gamboster
Gamboster previously approved these changes Sep 30, 2022
View reviewed changes
cmgustavo
cmgustavo previously approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@cmgustavo cmgustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gabrielbazan7 gabrielbazan7 dismissed stale reviews from cmgustavo and Gamboster via 2cc87a2 September 30, 2022 21:32
@JohnathanWhite JohnathanWhite merged commit 9e88741 into bitpay:master Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmgustavo cmgustavo cmgustavo approved these changes

@Gamboster Gamboster Gamboster left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gabrielbazan7 @lanchana @cmgustavo @Gamboster @JohnathanWhite @rastajpa