-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ref: Swap crypto #429
Merged
Merged
Ref: Swap crypto #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9065b7
to
f758257
Compare
969ee0d
to
61524bd
Compare
e06d651
to
dcdeb66
Compare
rastajpa
previously approved these changes
Oct 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work!
gabrielbazan7
previously approved these changes
Oct 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! ACK
gabrielbazan7
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
= Behavior of the "MAX" button:
=============
= Behavior of the walletTo selection modal:
=============
Fix: Some changelly tokens change their names arbitrarily. For each particular case there must be a translation to be able to support it within our app. For example:
In the ERC20 network:
USDT => It is called USDT20 by changelly
On the Matic network:
matic => It is called "maticpolygon" by changelly
usdc => It is called "usdcmatic" by changelly
=============
Added a control when all coins are disabled by Changelly. Now it shows an error messages saying "Our partner Changelly is not currently available. Please try again later."