[FIX] rate calculation when creating using crypto amount instead of usd #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msalcala11
requested changes
Sep 28, 2023
gabrielbazan7
dismissed stale reviews from cmgustavo and Gamboster
via
edce616
gabrielbazan7
force-pushed
the
fix/effective-rate
branch
from
7b0e9bf to
edce616
Compare
gabrielbazan7
force-pushed
the
fix/effective-rate
branch
from
edce616 to
9f37cd7
Compare
msalcala11
approved these changes
Sep 29, 2023
|
ACK! Tested the latest commit on a variety of scenarios, and this PR handles all of them well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choosing any other currency than usd here https://bitpay.com/demos/ results in incorrect rate calculations