Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] custom token using symbol not contract address #958

Merged
merged 7 commits into from
Nov 6, 2023

Conversation

gabrielbazan7
Copy link
Collaborator

@gabrielbazan7 gabrielbazan7 commented Oct 26, 2023

The format for storing supported ERC20 tokens now consists of the token's contract address followed by the chain it belongs to. Using symbols alone could not distinguish between tokens with identical symbols but different contract addresses.

Before testing

  • Make sure that you have ERC20 contacts (to test the contacts migration).
  • Make sure that you have ERC20 custom tokens (to test the custom tokens migration).

@gabrielbazan7 gabrielbazan7 force-pushed the ref/tokensData branch 4 times, most recently from f5dcb98 to 7b52600 Compare October 27, 2023 19:04
@gabrielbazan7 gabrielbazan7 changed the title WIP [REF] custom token using symbol not contract address [REF] custom token using symbol not contract address Oct 30, 2023
@gabrielbazan7 gabrielbazan7 changed the title [REF] custom token using symbol not contract address WIP [REF] custom token using symbol not contract address Oct 30, 2023
@gabrielbazan7 gabrielbazan7 force-pushed the ref/tokensData branch 9 times, most recently from 6966521 to 99437b9 Compare October 31, 2023 14:14
@gabrielbazan7 gabrielbazan7 changed the title WIP [REF] custom token using symbol not contract address [REF] custom token using symbol not contract address Oct 31, 2023
Copy link
Member

@cmgustavo cmgustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

TODO: test Coinbase integration

@JohnathanWhite JohnathanWhite merged commit 9ee39d9 into bitpay:master Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants