Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle-coveralls 1.0.0 #262

Closed
wants to merge 1 commit into from
Closed

gradle-coveralls 1.0.0 #262

wants to merge 1 commit into from

Conversation

vgaidarji
Copy link
Contributor

This simple step sends code coverage to www.coveralls.io. Uses ./gradlew for task execution.

@vgaidarji
Copy link
Contributor Author

I can't add labels, but please don't merge this one, as it's blocked by this PR. My pull request, which adds Bitrise support, was accepted, but the new version of library isn't released yet.

I saw assets folder with SVG icons in other steps. Who should add these icons?

is_always_run: false
is_skippable: true
inputs:
- gradlew_file_path: ./gradlew
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could set the default value to $GRADLEW_PATH, as you can see it in our Gradle Runner step ( https://github.com/bitrise-io/steps-gradle-runner/blob/master/step.yml#L55 ). This Env Var is configured automatically when you add a new Android project on bitrise.io, so that a user doesn't have to set the path of gradlew for every gradle step.

@viktorbenei
Copy link
Contributor

Re:Icons : if you have an SVG icon for the step you can add it yourself, or else we'll get or create one in the future.

@viktorbenei
Copy link
Contributor

Other then these, your step is perfect, thank you for the contribution!! 😊
If you'd decide to fix these issues for this version you can just:

  • close this PR
  • remove your step tag/release
  • change the things
  • re-create the tag/release
  • re-share the step

Or, if you'd rather submit it as a new version:

  • change the things
  • create a new tag/release
  • share the new version

@vgaidarji
Copy link
Contributor Author

Makes sense, I'll re-create it.

@vgaidarji vgaidarji closed this Jan 17, 2016
@vgaidarji vgaidarji mentioned this pull request Jan 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants