added projectType and step startTime #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trapacska
commented
Mar 11, 2019
| @@ -105,6 +105,7 @@ type StepIDData struct { | |||
|
|
|||
| // BuildRunResultsModel ... | |||
| type BuildRunResultsModel struct { | |||
| ProjectType string `json:"project_type" yaml:"project_type"` | |||
There was a problem hiding this comment.
trapacska
commented
Mar 11, 2019
| Status int `json:"status" yaml:"status"` | ||
| Idx int `json:"idx" yaml:"idx"` | ||
| RunTime time.Duration `json:"run_time" yaml:"run_time"` | ||
| StartTime time.Time `json:"start_time" yaml:"start_time"` |
There was a problem hiding this comment.
BirmacherAkos
previously approved these changes
Mar 11, 2019
godrei
reviewed
Mar 11, 2019
cli/run_util.go
Outdated
| RunTime: time.Now().Sub(stepStartTime), | ||
| ErrorStr: errStr, | ||
| ExitCode: exitCode, | ||
| StartTime: startTime, |
There was a problem hiding this comment.
why do not you use stepStartTime or the copy of stepStartTime if it would point to the last startTime?
godrei
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.