Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NOJIRA][2.3.2] updated env size limit to 256kb #196

Merged
merged 2 commits into from
Jun 30, 2021
Merged

[NOJIRA][2.3.2] updated env size limit to 256kb #196

merged 2 commits into from
Jun 30, 2021

Conversation

trapacska
Copy link
Contributor

No description provided.

@trapacska trapacska requested review from gaborszakacs and godrei June 30, 2021 07:23
gaborszakacs
gaborszakacs requested changes Jun 30, 2021
View reviewed changes
Copy link

@gaborszakacs gaborszakacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we have proper tests for this :)

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2021 •
edited
Loading

Codecov Report

Merging #196 (e3f6e34) into master (b2b4fe8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #196   +/-   ##
=======================================
  Coverage   36.93%   36.93%           
=======================================
  Files          12       12           
  Lines         704      704           
=======================================
  Hits          260      260           
  Misses        400      400           
  Partials       44       44
Impacted Files Coverage Δ
envman/configs.go 65.78% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b4fe8...e3f6e34. Read the comment docs.

@trapacska trapacska requested a review from gaborszakacs June 30, 2021 07:40
godrei
godrei approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@godrei godrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trapacska trapacska merged commit df85af5 into master Jun 30, 2021
@trapacska trapacska deleted the update-en-list-size-limit branch June 30, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godrei godrei godrei approved these changes

@gaborszakacs gaborszakacs gaborszakacs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trapacska @codecov-commenter @gaborszakacs @godrei