golint -> golangci-lint, fix CI #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofalvai
commented
Apr 8, 2024
| @@ -10,7 +10,7 @@ import ( | |||
| "github.com/urfave/cli" | |||
| ) | |||
|
|
|||
| func print(c *cli.Context) error { | |||
| func printCmd(c *cli.Context) error { | |||
There was a problem hiding this comment.
This function was shadowing the builtin print() function
ofalvai
commented
Apr 8, 2024
| - golint: { } | ||
| - errcheck: { } | ||
| - go-test: { } | ||
| - codecov: |
There was a problem hiding this comment.
This was already failing, so I decided to remove
godrei
reviewed
Apr 10, 2024
godrei
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The golint step no longer works without an
asdf reshim, and this is a good time to instead replacegolintwithgolangci-lintjust like in all of our repos.Enabled linters: all the default +
revive, which is a golint replacement.Other fixes in this PR:
PWDenv var in all tests. Nothing changed compared to the last good CI run 9 months ago, except for the default Go version on the stacks, so I can only think of a change inos.Environ()or the way the test process runs in newer Go versions. Either way, I think it's safe to exclude this env var when testing the envman output.