[PS-2215] Implement scrypt key derivation function #2285
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
This pull request implements the scrypt kdf, as the second kdf next to pbkdf2.
The corresponding pull request on the clients repository is here:
Edit @djsmith85: Community forum thread: https://community.bitwarden.com/t/scrypt-kdf-support/48148/1
Code changes
There is also a pull request for the clients implementation here: bitwarden/clients/pull/4428
I will note that I only tested this on Android, as I do not have a working iOS testing setup. It is the same implementation, but if it still does not work, let me know and I'm happy to fix it :)