Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14952] - show "close" button if user doesn't have edit permission in vault dialog trash #13036

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jaasen-livefront
Copy link
Collaborator

@jaasen-livefront jaasen-livefront commented Jan 23, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14952

📔 Objective

This PR replaces the "Edit" button with a "Cancel" button while a user without edit permission is viewing an item in the trash. It also cleans up a bit of the logic in the component.

📸 Screenshots

Before After
Screenshot 2025-01-23 at 11 29 15 AM Screenshot 2025-01-23 at 11 51 35 AM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jaasen-livefront jaasen-livefront requested a review from a team as a code owner January 23, 2025 19:30
@jaasen-livefront jaasen-livefront changed the title [PM-14952] - show cancel button if user doesn't have edit permission in vault dialog trash [PM-14952] - show "close" button if user doesn't have edit permission in vault dialog trash Jan 23, 2025
Copy link
Contributor

github-actions bot commented Jan 23, 2025

Logo
Checkmarx One – Scan Summary & Details02487feb-8e7d-4961-96a8-ab2674b10d85

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 35.11%. Comparing base (649a196) to head (4612069).
Report is 14 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/vault-item-dialog/vault-item-dialog.component.ts 12.50% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #13036    +/-   ##
========================================
  Coverage   35.10%   35.11%            
========================================
  Files        2990     3000    +10     
  Lines       91071    91301   +230     
  Branches    17049    17092    +43     
========================================
+ Hits        31968    32056    +88     
- Misses      56610    56743   +133     
- Partials     2493     2502     +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant