Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire passkey autofill to UI #13051

Draft
wants to merge 11 commits into
base: passkey-window-creation
Choose a base branch
from

Conversation

abergs
Copy link
Member

@abergs abergs commented Jan 24, 2025

🎟️ Tracking

📔 Objective

Wire the FIDO2 autofill integration with the UI.

TODO:

  • Rename the /passkeys path to fido2
  • remove usage of messagingservices (only used for dev-debugging)
  • Cleanup/hide the swift UI popup "autofill-extension hello"

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@abergs abergs changed the title Use Messaging service to loadUrl Wire passkey autofill to UI Jan 24, 2025
Copy link
Contributor

github-actions bot commented Jan 24, 2025

Logo
Checkmarx One – Scan Summary & Details5323c001-7b9d-4a03-89ae-a8ecc656117f

New Issues (15)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
CRITICAL CVE-2025-0611 Npm-electron-33.2.1 Vulnerable Package
HIGH CVE-2025-0434 Npm-electron-33.2.1 Vulnerable Package
HIGH CVE-2025-0436 Npm-electron-33.2.1 Vulnerable Package
HIGH CVE-2025-0437 Npm-electron-33.2.1 Vulnerable Package
HIGH CVE-2025-0438 Npm-electron-33.2.1 Vulnerable Package
HIGH CVE-2025-0443 Npm-electron-33.2.1 Vulnerable Package
HIGH CVE-2025-0447 Npm-electron-33.2.1 Vulnerable Package
HIGH CVE-2025-0612 Npm-electron-33.2.1 Vulnerable Package
MEDIUM CVE-2025-0435 Npm-electron-33.2.1 Vulnerable Package
MEDIUM CVE-2025-0439 Npm-electron-33.2.1 Vulnerable Package
MEDIUM CVE-2025-0440 Npm-electron-33.2.1 Vulnerable Package
MEDIUM CVE-2025-0441 Npm-electron-33.2.1 Vulnerable Package
MEDIUM CVE-2025-0442 Npm-electron-33.2.1 Vulnerable Package
MEDIUM CVE-2025-0446 Npm-electron-33.2.1 Vulnerable Package
MEDIUM CVE-2025-0448 Npm-electron-33.2.1 Vulnerable Package
Fixed Issues (1)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM Cx14b19a02-387a Npm-body-parser-1.20.3

Copy link
Contributor

@coroiu coroiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the right track

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants