[PM-17168] Sync organization user revoked/restored status immediately via push notification #13101
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wait for reconnect
… in a separate method
…diately-via-push-notification
…OrgKeysOnRevokeRestore
r-tome
changed the title
|
Fixed Issues (1)Great job! The following issues were fixed in this Pull Request
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13101 +/- ##
=======================================
Coverage 35.41% 35.42%
=======================================
Files 3007 3007
Lines 90716 90722 +6
Branches 16858 16859 +1
=======================================
+ Hits 32129 32140 +11
+ Misses 56123 56118 -5
Partials 2464 2464 ☔ View full report in Codecov by Sentry. |
eliykat
reviewed
Jan 30, 2025
|
I'm closing this because only the server change is required. |
…diately-via-push-notification
|
Reopening this PR — @eliykat explained that we need to refresh the identity token to update the claims. |
BTreston
previously approved these changes
Feb 3, 2025
eliykat
previously approved these changes
Feb 3, 2025
eliykat
reviewed
Feb 3, 2025
| @@ -182,6 +187,9 @@ export class DefaultNotificationsService implements NotificationsServiceAbstract | |||
| await this.syncService.fullSync(true); | |||
| break; | |||
| case NotificationType.SyncOrgKeys: | |||
| if (await this.configService.getFeatureFlag(FeatureFlag.PushSyncOrgKeysOnRevokeRestore)) { | |||
| await this.apiService.refreshIdentityToken(); | |||
There was a problem hiding this comment.
I think a comment here would be useful, e.g. // refresh identity token to update organization roles in the JWT claims.
…diately-via-push-notification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17168
📔 Objective
This PR updates the
NotificationsServiceto handle messages of typeNotificationType.SyncOrgKeysby refreshing the identity token.I also noticed that the SignalR connection stops when receiving a
NotificationType.SyncOrgKeysmessage but does not restart automatically. To fix this, I updated the reconnect method to re-setup the connection.Server PR.
📸 Screenshots
Revoking and restoring a user a couple of times:
Screen.Recording.2025-01-28.at.12.41.05.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes